[
https://issues.apache.org/jira/browse/HIVE-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878343#comment-13878343
]
Jitendra Nath Pandey commented on HIVE-6183:
--------------------------------------------
The code looks good. +1
Some minor comments.
* DecimalColumnVector#checkPrecisionOverflow should catch a more specific
exception for overflow.
* CastDecimalToDecimal#func is too generic a name. We could rename it to
something indicating what it does.
* CastDecimalToTimestamp#initialize: tmp and tmpE9 can be initialized
statically in the class. It seems we can get rid of the initialize method from
the base classes as well.
> Implement vectorized type cast from/to decimal(p, s)
> ----------------------------------------------------
>
> Key: HIVE-6183
> URL: https://issues.apache.org/jira/browse/HIVE-6183
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 0.13.0
> Reporter: Eric Hanson
> Assignee: Eric Hanson
> Attachments: HIVE-6183.07.patch, HIVE-6183.08.patch
>
>
> Add support for all the type supported type casts to/from decimal(p,s) in
> vectorized mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
