----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17302/#review32697 -----------------------------------------------------------
Very well unit-tested. Just to cover the full test: it will be much better if you can add a .q test something like decimal_udf.q? Basically the same q file after setting new config to backward compat mode. the result could be different. - Mohammad Islam On Jan. 24, 2014, 2:54 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17302/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 2:54 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6012 > https://issues.apache.org/jira/browse/HIVE-6012 > > > Repository: hive-git > > > Description > ------- > > Change return types back to Hive-0.12 behavior for the following math > operators: > int / int -> decimal, used to be double in Hive-0.12 > float + int -> double, used to be float in Hive-0.12 > float + float -> double, used to be float in Hive-0.12 > float * int -> double, used to be float in Hive-0.12 > float * float -> double, used to be float in Hive-0.12 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 371cb0f > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java > 28b5ffd > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java > 9a04e81 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java > e894b54 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java > d7285d9 > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java > ef17eb5 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java > 56472f0 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java > 6193257 > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java > 702e3e7 > > Diff: https://reviews.apache.org/r/17302/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
