----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review33332 -----------------------------------------------------------
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java <https://reviews.apache.org/r/17483/#comment62772> Ah. I see your point now. Nice catch! I can make that fix. > All composite keys must extend HBaseCompositeKey, correct? Not necessarily. For some composite keys which are simple enough for hive to understand, a custom implementation isn't needed. For instance see my first comment on the JIRA[1]. If someone has some crazy custom logic to create composite keys, then they would probably need to create their own extension of HBaseCompositeKey class to help hive understand their keys. [1] https://issues.apache.org/jira/browse/HIVE-2599?focusedCommentId=13422237&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13422237 - Swarnim Kulkarni On Jan. 29, 2014, 6:04 a.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17483/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 6:04 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6290 > https://issues.apache.org/jira/browse/HIVE-6290 > > > Repository: hive-git > > > Description > ------- > > Support to be able to provide scan filter for hive/hbase integration for > composite keys. > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java > 5008f15 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 899ccce > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 704fcb9 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestCompositeKey.java > 13c344b > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > d39ee2e > ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 5f1329c > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java e50026b > > Diff: https://reviews.apache.org/r/17483/diff/ > > > Testing > ------- > > Tested using locally created data and debug logs that the filter gets applied > on the scan. > > > Thanks, > > Swarnim Kulkarni > >
