[
https://issues.apache.org/jira/browse/HIVE-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892996#comment-13892996
]
Swarnim Kulkarni commented on HIVE-2599:
----------------------------------------
{quote}
Could I ask why LazySimpleStructObjectInspector started to make new List for
getStructFieldsDataAsList()?
{quote}
Basically a bit of testing convenience on my side. Also tried to make the
implementation here similar to some of the existing ObjectInspectors[1]. It
tried my best to ensure that this passed all existing tests and also wasn't
violating any obvious contracts on the class. Did I miss something?
{quote}
I cannot understand the intention of this issue.
{quote}
You are correct in the sense that a basic struct doesn't need a custom
HBaseCompositeKey implementation(also refer to my first comment on this JIRA
for another example). But there are increasing number of cases where custom and
more complicated serializers are written to serialize the keys in a more
efficient way (salting is such an example). For such serializers, a custom
HBaseCompositeKey implementation would help hive understand such complicated
keys.
[1]
https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java#L174
[2]
https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java#L153
> Support Composit/Compound Keys with HBaseStorageHandler
> -------------------------------------------------------
>
> Key: HIVE-2599
> URL: https://issues.apache.org/jira/browse/HIVE-2599
> Project: Hive
> Issue Type: Improvement
> Components: HBase Handler
> Affects Versions: 0.8.0
> Reporter: Hans Uhlig
> Assignee: Swarnim Kulkarni
> Fix For: 0.13.0
>
> Attachments: HIVE-2599.1.patch.txt, HIVE-2599.2.patch.txt,
> HIVE-2599.2.patch.txt, HIVE-2599.3.patch.txt, HIVE-2599.4.patch.txt
>
>
> It would be really nice for hive to be able to understand composite keys from
> an underlying HBase schema. Currently we have to store key fields twice to be
> able to both key and make data available. I noticed John Sichi mentioned in
> HIVE-1228 that this would be a separate issue but I cant find any follow up.
> How feasible is this in the HBaseStorageHandler?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
