[ 
https://issues.apache.org/jira/browse/HIVE-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901988#comment-13901988
 ] 

Lefty Leverenz commented on HIVE-6406:
--------------------------------------

Here's a Valentine nit for you in ErrorMsg.java:

bq.  INSERT_INTO_IMMUTABLE_TABLE(10256, "Inserting into an non-empty immutable 
table is not allowed"),

... should be "a non-empty" (also fix in insert_into5.q.out & 
insert_into6.q.out).

And another in hive_metastore.thrift:

{quote}
+// Whether or not the table is considered immutable - immutable tables can 
only be
+// overwritten or created if unpartitioned, or if partitioned, partitions 
inside it
+// can only be overwritten or created. Immutability supports write-once and 
replace
+// semantics, but not append.
{quote}

... "immutable tables" doesn't match "inside it" so change to "an immutable 
table" (or "them").

> Introduce immutable-table table property and if set, disallow insert-into
> -------------------------------------------------------------------------
>
>                 Key: HIVE-6406
>                 URL: https://issues.apache.org/jira/browse/HIVE-6406
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog, Metastore, Query Processor, Thrift API
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-6406.2.patch, HIVE-6406.patch
>
>
> As part of HIVE-6405's attempt to make HCatalog and Hive behave in similar 
> ways with regards to immutable tables, this is a companion task to introduce 
> the notion of an immutable table, wherein all tables are not immutable by 
> default, and have this be a table property. If this property is set for a 
> table, and we attempt to write to a table that already has data (or a 
> partition), disallow "INSERT INTO" into it from hive(if destination directory 
> is non-empty). This property being set will allow hive to mimic HCatalog's 
> current immutable-table property.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to