----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/#review34728 -----------------------------------------------------------
@Vaibhav, thanks for the patch and following up on the overall async execution line items! The patch itself looks fine on the first pass. I do have a high level question on the approach. The patch enables async execution by defaults on client side and adds synchronous wait top of that. This IHMO defeats the purpose of the aysnc execution. From the application point of view, there's no difference in the behavior with or without this patch. The execution will block till the query execution is complete. The rationale of async execution is to return control back to client immediately so that the client has an option to perform alternate foreground work while the query is being processed. Have you considered blocking in fetch for queries with resultset ? That in would give more time for server to process the query in parallel while client examines the resultset description and possible interact with end user etc. - Prasad Mujumdar On Feb. 18, 2014, 2:22 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14950/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 2:22 p.m.) > > > Review request for hive and Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > Should be applied on top of: > HIVE-5217 [Add long polling to asynchronous execution in HiveServer2] > HIVE-5229 [Better thread management for HiveServer2 async threads] > HIVE-5230 [Better error reporting by async threads in HiveServer2] > HIVE-5441 [Async query execution doesn't return resultset status] > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java f0d0c77 > > Diff: https://reviews.apache.org/r/14950/diff/ > > > Testing > ------- > > TestJdbcDriver2 > > > Thanks, > > Vaibhav Gumashta > >
