-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 9:18 p.m.)
Review request for hive.
Changes
-------
Addresses review items.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
Decouples the STORED AS keywords from the language using the service loader
construct.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
36a6e0c
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
ec24531
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java
PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java
PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af2536
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java
PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientpositive/storage_format_descriptor.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/18224/diff/
Testing
-------
Ran a bunch of random tests and it seems to work. Precommit testing will run
the full suite.
Thanks,
Brock Noland
