> On Feb. 19, 2014, 2:27 p.m., Brock Noland wrote: > > conf/hive-default.xml.template, line 335 > > <https://reviews.apache.org/r/17694/diff/3/?file=497527#file497527line335> > > > > This one is getting populated and will be tough to fix. Perhaps we add > > an if block on the ant code for this key?
There is an option in ConfVar for excluding from templates, mostly hadoop related confs. I missed HADOOPBIN. Will be fixed. > On Feb. 19, 2014, 2:27 p.m., Brock Noland wrote: > > common/pom.xml, line 150 > > <https://reviews.apache.org/r/17694/diff/3/?file=497519#file497519line150> > > > > What are your thoughts to adding this to a profile like the protobuf > > stuff so it only runs when the profile is specified? > > > > https://github.com/apache/hive/blob/trunk/ql/pom.xml#L378 I thought template file should be generated whenever HiveConf is changed. If it's driven by some profile, it would be prone to be missed. Isn't it? - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17694/#review34862 ----------------------------------------------------------- On Feb. 19, 2014, 7:05 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17694/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 7:05 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6037 > https://issues.apache.org/jira/browse/HIVE-6037 > > > Repository: hive-git > > > Description > ------- > > see HIVE-5879 > > > Diffs > ----- > > common/pom.xml b3d230d > common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 > common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/Validator.java PRE-CREATION > common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java a31238b > common/src/test/org/apache/hadoop/hive/conf/TestHiveConfRestrictList.java > a7270a2 > common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java d8cdd57 > conf/hive-default.xml.template 0d08aa2 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java > dac62d5 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 4df4dd5 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 29f1e57 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java cc840be > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 00d38f2 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java eafbeff > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1f539ef > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g aea9c1c > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 4d58f96 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > b1d3371 > ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java > f292944 > ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 409e0a7 > ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 93c89de > ql/src/java/org/apache/hadoop/hive/ql/plan/ShowConfDesc.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 92d5e75 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java > f1671ba > ql/src/test/queries/clientpositive/show_conf.q PRE-CREATION > ql/src/test/results/clientpositive/show_conf.q.out PRE-CREATION > service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a > > Diff: https://reviews.apache.org/r/17694/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
