----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18318/#review35099 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java <https://reviews.apache.org/r/18318/#comment65504> I think it is safer to do a case sensitive comparison, as hadoop usual configurations have case sensitive usernames. Even if username is case insensitive we can expect the case usage to be consistent. - Thejas Nair On Feb. 20, 2014, 7:21 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18318/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 7:21 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6474 > https://issues.apache.org/jira/browse/HIVE-6474 > > > Repository: hive-git > > > Description > ------- > > Only db owner is allowed to create table in db. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java > 7dfd574 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java > c59b403 > ql/src/test/queries/clientnegative/authorize_create_tbl.q PRE-CREATION > ql/src/test/results/clientnegative/authorize_create_tbl.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/18318/diff/ > > > Testing > ------- > > Added new test case. > > > Thanks, > > Ashutosh Chauhan > >
