----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18202/#review35218 -----------------------------------------------------------
service/src/java/org/apache/hive/service/auth/HttpAuthHelper.java <https://reviews.apache.org/r/18202/#comment65672> this check looks unnecessary. It is returning same object irrespective of value. - Thejas Nair On Feb. 18, 2014, 3:02 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18202/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 3:02 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-6306 > https://issues.apache.org/jira/browse/HIVE-6306 > > > Repository: hive-git > > > Description > ------- > > HiveServer2 running in http mode should support for doAs functionality > > > Diffs > ----- > > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8ba3aa > service/src/java/org/apache/hive/service/auth/HttpAuthHelper.java > PRE-CREATION > service/src/java/org/apache/hive/service/auth/HttpCLIServiceProcessor.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpCLIServiceUGIProcessor.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > bfe0e7b > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > a6ff6ce > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java > e77f043 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 9e9a60d > > Diff: https://reviews.apache.org/r/18202/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >