[ 
https://issues.apache.org/jira/browse/HIVE-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909547#comment-13909547
 ] 

Hive QA commented on HIVE-6459:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12630096/HIVE-6459.2.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5175 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_udf
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
{noformat}

Test results: 
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1444/testReport
Console output: 
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1444/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12630096

> Change the precison/scale for intermediate sum result in the avg() udf 
> -----------------------------------------------------------------------
>
>                 Key: HIVE-6459
>                 URL: https://issues.apache.org/jira/browse/HIVE-6459
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.13.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-6459.1.patch, HIVE-6459.2.patch, HIVE-6459.patch
>
>
> The avg() udf, when applied to a decimal column, selects the precision/scale 
> of the intermediate sum field as (p+4, s+4), which is the same for the 
> precision/scale of the avg() result. However, the additional scale increase 
> is unnecessary, and the problem of data overflow may occur. The requested 
> change is that for the intermediate sum result,  the precsion/scale is set to 
> (p+10, s), which is consistent to sum() udf. The avg() result still keeps its 
> precision/scale.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to