[ 
https://issues.apache.org/jira/browse/HIVE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915999#comment-13915999
 ] 

Ashutosh Chauhan commented on HIVE-3938:
----------------------------------------

+1
 [~mithun] Can you re-upload the patch with name HIVE-3938.patch That way Hive 
QA will pick it up to run test suite.

One thing which is disturbing in current code base is (which existed even 
before this patch) is we are running these pre and post hooks within 
transaction. General wisdom is to never make calls to foreign system (like 
MsgBus in our case) from within database transaction. We should try to improve 
this, though thats probably a topic for another jira.

> Hive MetaStore should send a single AddPartitionEvent for atomically added 
> partition-set.
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-3938
>                 URL: https://issues.apache.org/jira/browse/HIVE-3938
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.10.0, 0.11.0, 0.12.0
>            Reporter: Mithun Radhakrishnan
>            Assignee: Mithun Radhakrishnan
>         Attachments: HIVE-3938.trunk.2.patch, 
> Hive-3938-Support_for_Multi-table-insert.patch
>
>
> HiveMetaStore::add_partitions() currently adds all partitions specified in 
> one call using a single meta-store transaction. This acts correctly. However, 
> there's one AddPartitionEvent created per partition specified.
> Ideally, the set of partitions added atomically can be communicated using a 
> single AddPartitionEvent, such that they are consumed together.
> I'll post a patch that does this.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to