-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18588/#review36013
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/18588/#comment66804>

    nit: spacing here and above



ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/18588/#comment66805>

    why is this change in this patch?


- Sergey Shelukhin


On March 2, 2014, 12:52 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18588/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 12:52 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6440
>     https://issues.apache.org/jira/browse/HIVE-6440
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> It should be possible to change the owner of a database once it is created.
> Also includes a small change to authorize drop database, as it is better 
> tested with this alter-db-owner functionality.
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/negative/cascade_dbdrop_hadoop20.q.out 
> c5bfd6a 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  7fbb67e 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> d60cb1b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4310ab8 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 2484576 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 8356155 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 129c6c6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 6bf2a17 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
> b1d3371 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationParseUtils.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java
>  4dbe78c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java 16bb95b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java e661f00 
>   
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java
>  f1671ba 
>   
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java
>  c43bcea 
>   ql/src/test/queries/clientnegative/authorization_alter_db_owner.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/authorization_alter_db_owner_default.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/authorization_drop_db_cascade.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/authorization_drop_db_empty.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/alter_db_owner.q PRE-CREATION 
>   ql/src/test/results/clientnegative/authorization_alter_db_owner.q.out 
> PRE-CREATION 
>   
> ql/src/test/results/clientnegative/authorization_alter_db_owner_default.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/authorization_drop_db_cascade.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/authorization_drop_db_empty.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/alter_db_owner.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/database.q.out cdaa405 
>   ql/src/test/results/clientpositive/database_drop.q.out 3128561 
>   ql/src/test/results/clientpositive/database_properties.q.out e3e2816 
>   
> ql/src/test/results/clientpositive/drop_database_removes_partition_dirs.q.out 
> 475d3d0 
>   ql/src/test/results/clientpositive/input46.q.out a891362 
>   ql/src/test/results/clientpositive/udf_using.q.out 69e5f3b 
> 
> Diff: https://reviews.apache.org/r/18588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Reply via email to