----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18914/#review36559 -----------------------------------------------------------
Thanks Brock for the change! Just a minor comment. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java <https://reviews.apache.org/r/18914/#comment67562> Looks like there is a class called 'serdeConstants' that has typeName finals, that we can use for these hard-coded strings? - Szehon Ho On March 7, 2014, 6:25 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18914/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 6:25 p.m.) > > > Review request for hive, Szehon Ho and Xuefu Zhang. > > > Bugs: HIVE-6457 > https://issues.apache.org/jira/browse/HIVE-6457 > > > Repository: hive-git > > > Description > ------- > > Improved error messages for unsupported types. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java > a2c7fe0 > ql/src/test/queries/clientnegative/parquet_char.q PRE-CREATION > ql/src/test/queries/clientnegative/parquet_date.q PRE-CREATION > ql/src/test/queries/clientnegative/parquet_decimal.q PRE-CREATION > ql/src/test/queries/clientnegative/parquet_timestamp.q PRE-CREATION > ql/src/test/queries/clientnegative/parquet_varchar.q PRE-CREATION > ql/src/test/results/clientnegative/parquet_char.q.out PRE-CREATION > ql/src/test/results/clientnegative/parquet_date.q.out PRE-CREATION > ql/src/test/results/clientnegative/parquet_decimal.q.out PRE-CREATION > ql/src/test/results/clientnegative/parquet_timestamp.q.out PRE-CREATION > ql/src/test/results/clientnegative/parquet_varchar.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/18914/diff/ > > > Testing > ------- > > New tests pass. > > > Thanks, > > Brock Noland > >
