----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18992/#review36880 -----------------------------------------------------------
Ship it! +1 , after minor comments. ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java <https://reviews.apache.org/r/18992/#comment68074> It will be better to include a more informative error message including job id and exception. - Mohammad Islam On March 10, 2014, 11:39 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18992/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 11:39 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6609 > https://issues.apache.org/jira/browse/HIVE-6609 > > > Repository: hive-git > > > Description > ------- > > Switched to java api to kill jobs instead of url based job killing. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > a4585de > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java > 5a6899c > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java > 4b58d92 > > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java > 21b537c > ql/src/java/org/apache/hadoop/hive/ql/plan/ReducerTimeStatsPerJob.java > 40c27e3 > > Diff: https://reviews.apache.org/r/18992/diff/ > > > Testing > ------- > > Manually tested for both Hadoop-1 & Hadoop-2. Working as expected. > > > Thanks, > > Ashutosh Chauhan > >