----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19150/ -----------------------------------------------------------
(Updated March 13, 2014, 3:44 p.m.) Review request for hive and Thejas Nair. Changes ------- Thank you for the review! I believe I have addressed the feedback in the updated patch. Repository: hive-git Description ------- 1) Changes SET ROLE NONE to SET ROLE ALL. 2) Reserves the keywords NONE and DEFAULT. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g cdfa300 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g a74da0e ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 53a461f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java f69e41b ql/src/test/queries/clientnegative/authorization_cannot_create_all_role.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_cannot_create_default_role.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_cannot_create_none_role.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_disallow_transform.q bae8dc0 ql/src/test/queries/clientnegative/authorization_drop_role_no_admin.q 80346d4 ql/src/test/queries/clientpositive/authorization_set_show_current_role.q 7fe8e29 ql/src/test/results/clientnegative/authorization_cannot_create_all_role.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_cannot_create_default_role.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_cannot_create_none_role.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_disallow_transform.q.out 044b19e ql/src/test/results/clientnegative/authorization_drop_role_no_admin.q.out d2cc1dd ql/src/test/results/clientpositive/authorization_set_show_current_role.q.out 5c39a06 Diff: https://reviews.apache.org/r/19150/diff/ Testing ------- All tests which call SET ROLE were manually tested. Thanks, Brock Noland
