[ 
https://issues.apache.org/jira/browse/HIVE-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949752#comment-13949752
 ] 

Szehon Ho commented on HIVE-6694:
---------------------------------

Nice, it looks good.  One minor suggestion is to remove the commented code.  

That brings up a question, Hive CLI does variable substitution, but here it is 
commented (not sure intentionally?).  Why the difference, is it to prevent 
collision with shell variables?

> Beeline should provide a way to execute shell command as Hive CLI does
> ----------------------------------------------------------------------
>
>                 Key: HIVE-6694
>                 URL: https://issues.apache.org/jira/browse/HIVE-6694
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI, Clients
>    Affects Versions: 0.11.0, 0.12.0, 0.13.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-6694.patch
>
>
> Hive CLI allows a user to execute a shell command using ! notation. For 
> instance, !cat myfile.txt. Being able to execute shell command may be 
> important for some users. As a replacement, however, Beeline provides no such 
> capability, possibly because ! notation is reserved for SQLLine commands. 
> It's possible to provide this using a slightly syntactic variation such as 
> !sh cat myfilie.txt.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to