----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19789/#review39521 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java <https://reviews.apache.org/r/19789/#comment71934> Document all the input params/just rename the params to reflect their use. hdfsPathStr is the destination directory right? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java <https://reviews.apache.org/r/19789/#comment71932> Actually looks like this method localizes an array of files. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java <https://reviews.apache.org/r/19789/#comment71933> Definitely needs method(s) renaming. ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java <https://reviews.apache.org/r/19789/#comment71936> Open a jira for this. ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java <https://reviews.apache.org/r/19789/#comment71938> Aren't you walking the work graph here to populate the job conf? - Vikram Dixit Kumaraswamy On April 3, 2014, 2:26 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19789/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 2:26 a.m.) > > > Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > See jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 78e965b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 720b8d5 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 5f0f353 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 385e22e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java fdbd996 > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 38c4c11 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java e1cc3f4 > ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java 996268e > ql/src/java/org/apache/hadoop/hive/ql/plan/UnionWork.java 60781e6 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 93eccf8 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > d2c332c > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java > 5ad4250 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 4810fd0 > > Diff: https://reviews.apache.org/r/19789/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
