[ https://issues.apache.org/jira/browse/HIVE-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961928#comment-13961928 ]
Lars Francke commented on HIVE-5687: ------------------------------------ To add to Owen's style guidelines thing: Just throwing this patch in my IDE gives me a lot of warnings and errors. Things like: * missorted modifiers (static final private -> private static final) * Unnecessary package-level visibility * Redundant exceptions in throws clauses * Some very weird formatting * Call to simple getters from within class * for loop without initializer that can be a while loop * Unused variables * Conditions that are always true or false * Empty Javadoc tags * Unnecessary "this" * Missing @Override annotations * StringBuffer usage * Modifiers in interfaces (public) etc. I'm happy to do a full review on ReviewBoard but these are all things that Eclipse and IntelliJ can show you out of the box. So I'd appreciate it if you could set your IDE up to show these things and fix them in addition to using proper code formatting. Contact me if I can help in any way. > Streaming support in Hive > ------------------------- > > Key: HIVE-5687 > URL: https://issues.apache.org/jira/browse/HIVE-5687 > Project: Hive > Issue Type: Sub-task > Reporter: Roshan Naik > Assignee: Roshan Naik > Labels: ACID, Streaming > Fix For: 0.13.0 > > Attachments: 5687-api-spec4.pdf, 5687-draft-api-spec.pdf, > 5687-draft-api-spec2.pdf, 5687-draft-api-spec3.pdf, > HIVE-5687-unit-test-fix.patch, HIVE-5687.patch, HIVE-5687.v2.patch, > HIVE-5687.v3.patch, HIVE-5687.v4.patch, HIVE-5687.v5.patch, Hive Streaming > Ingest API for v3 patch.pdf, Hive Streaming Ingest API for v4 patch.pdf > > > Implement support for Streaming data into HIVE. > - Provide a client streaming API > - Transaction support: Clients should be able to periodically commit a batch > of records atomically > - Immediate visibility: Records should be immediately visible to queries on > commit > - Should not overload HDFS with too many small files > Use Cases: > - Streaming logs into HIVE via Flume > - Streaming results of computations from Storm -- This message was sent by Atlassian JIRA (v6.2#6252)