-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20243/
-----------------------------------------------------------
(Updated April 11, 2014, 11:41 p.m.)
Review request for hive.
Changes
-------
Mkdirs will change only the group as discussed, as hive is not superuser.
Tested on a cluster, verified it works as expected if hive is a member of that
group.
I will try to refactor the unit test with MiniDFS to verify the group part in a
follow-up JIRA, as I cannot create other groups as its running on real local
file system.
Bugs: HIVE-6891
https://issues.apache.org/jira/browse/HIVE-6891
Repository: hive-git
Description
-------
This is a follow-up of HIVE-6648.
Extending the fix to other partition/table operations as well, by refactoring
the fixed code in HIVE-6648 into a common FileUtils helper method, and then
using it for all table/partition directory creation operation, when
"hive.warehouse.subdir.inherit.perms" flag is set.
Another part of this change is to add ownership inheritance in this code as
well when creating directories. Ownership was already inherited for data
(HIVE-3756), but not at the table/partitioned-table level.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java ad82f62
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java
f1c7b7b
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
8345d70
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
c62e085
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java f731dab
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2559e0e
Diff: https://reviews.apache.org/r/20243/diff/
Testing
-------
Extending the unit test TestFolderPermission to handle all the new cases of
directory creation (create table, external table, static partition, dynamic
partition, rename partition).
Unfortunately due to the test using the local file system, I cannot add the
ownership inheritance to unit-testing. I can probably look into using MiniDFS
for that, in a follow-up JIRA.
Thanks,
Szehon Ho
