[ 
https://issues.apache.org/jira/browse/HIVE-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981853#comment-13981853
 ] 

Thejas M Nair commented on HIVE-4577:
-------------------------------------

[~bingl]
Sorry about the delay in getting your patch in.
Looks like the patch didn't apply properly on trunk.
I took a look at the patch, I think it would be better to use this library - 
http://commons.apache.org/proper/commons-lang/javadocs/api-2.4/org/apache/commons/lang/text/StrTokenizer.html#StrTokenizer(java.lang.String,
 org.apache.commons.lang.text.StrMatcher, 
org.apache.commons.lang.text.StrMatcher) .
We already include that library in hive. Reusing it would mean the chances of 
bugs are lower.

As [~appodictic] mentioned, can you also include "dfs -ls " commands that show 
the files in output ? (Or any command that verifies that the files got created 
as expected).


> hive CLI can't handle hadoop dfs command  with space and quotes.
> ----------------------------------------------------------------
>
>                 Key: HIVE-4577
>                 URL: https://issues.apache.org/jira/browse/HIVE-4577
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 0.9.0, 0.10.0
>            Reporter: Bing Li
>            Assignee: Bing Li
>             Fix For: 0.14.0
>
>         Attachments: HIVE-4577.1.patch, HIVE-4577.2.patch, 
> HIVE-4577.3.patch.txt
>
>
> As design, hive could support hadoop dfs command in hive shell, like 
> hive> dfs -mkdir /user/biadmin/mydir;
> but has different behavior with hadoop if the path contains space and quotes
> hive> dfs -mkdir "hello"; 
> drwxr-xr-x   - biadmin supergroup          0 2013-04-23 09:40 
> /user/biadmin/"hello"
> hive> dfs -mkdir 'world';
> drwxr-xr-x   - biadmin supergroup          0 2013-04-23 09:43 
> /user/biadmin/'world'
> hive> dfs -mkdir "bei jing";
> drwxr-xr-x   - biadmin supergroup          0 2013-04-23 09:44 
> /user/biadmin/"bei
> drwxr-xr-x   - biadmin supergroup          0 2013-04-23 09:44 
> /user/biadmin/jing"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to