----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21095/ -----------------------------------------------------------
Review request for hive and Brock Noland. Repository: hive-git Description ------- There was some reported permission errors hit in Fs.setOwner during table creation, when the inherit permission flag was on. I realized that HDFS follows the BSD rule and anyway sets new directory to be the same group as the parent, so actually no need to call 'setOwner' for changing the group during mkdirs. Minor cleanups elsewhere. Changed the other call in mkdirs (Fs.setPermission) to use the shell, so it doesnt throw an error (although I don't see why it should, as folder should be owned by the current user whether its impersonated user or hive). Also changing other places as well to not throw error on failure, although again they shouldn't have failed as these were already using the shell. Diffs ----- common/src/java/org/apache/hadoop/hive/common/FileUtils.java 23a4b8e ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873 Diff: https://reviews.apache.org/r/21095/diff/ Testing ------- Ran TestFolderPermissions. Thanks, Szehon Ho
