[ 
https://issues.apache.org/jira/browse/HIVE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016143#comment-14016143
 ] 

David Chen commented on HIVE-7094:
----------------------------------

The above test failures are due to HIVE-7085 and do not appear to be related to 
this patch.

> Separate out static/dynamic partitioning code in FileRecordWriterContainer
> --------------------------------------------------------------------------
>
>                 Key: HIVE-7094
>                 URL: https://issues.apache.org/jira/browse/HIVE-7094
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: HIVE-7094.1.patch
>
>
> There are two major places in FileRecordWriterContainer that have the {{if 
> (dynamicPartitioning)}} condition: the constructor and write().
> This is the approach that I am taking:
> # Move the DP and SP code into two subclasses: 
> DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer.
> # Make FileRecordWriterContainer an abstract class that contains the common 
> code for both implementations. For write(), FileRecordWriterContainer will 
> call an abstract method that will provide the local RecordWriter, 
> ObjectInspector, SerDe, and OutputJobInfo.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to