> On May 23, 2014, 5:54 a.m., Swarnim Kulkarni wrote: > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 591 > > <https://reviews.apache.org/r/21846/diff/2/?file=589240#file589240line591> > > > > Minor but this method seems to be doing more than just renaming. Should > > probably update the method name to be descriptive of what it does.
Swarnim, I did change the method name to renameAndInheritPermissions, but then I realized its not required as the parameter inheritPerms kind of makes the intent of inheriting permissions clear. Having the long name seemed redundant. I am reverting the name to rename. Let me know if you do not agree. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review43813 ----------------------------------------------------------- On May 28, 2014, 10:10 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21846/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 10:10 p.m.) > > > Review request for hive and Szehon Ho. > > > Bugs: HIVE-7117 > https://issues.apache.org/jira/browse/HIVE-7117 > > > Repository: hive-git > > > Description > ------- > > Change table name to have all lowercase letters. Looks like table name is > toLower'ed by hive while creating file > > Avoid using same table in two different tests > > HIVE-7117: Partitions not inheriting table permissions after alter rename > partition > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java > ee61350ab1d32db96a234f6444836f76e23f3251 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java > 4f566d2a2999eecea7018836505208ae80662e97 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 221b01043b3520211643847c00b17b328ad2b9c0 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > c1790b427e7fa64780fdf0a580f28135d6a4ff8d > > Diff: https://reviews.apache.org/r/21846/diff/ > > > Testing > ------- > > Tested with itests. > > > Thanks, > > Ashish Singh > >
