[ https://issues.apache.org/jira/browse/HIVE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034418#comment-14034418 ]
David Chen commented on HIVE-7094: ---------------------------------- The Hive CLI and QL test failures are unrelated to my patch. The only one that is concerning to me is the TestOrcHCatLoader failure. However, I am not hitting that failure when I run the tests on my machine, but I have rebased my changes on the current trunk. Nonetheless, all of the HCatalog Core tests pass. > Separate out static/dynamic partitioning code in FileRecordWriterContainer > -------------------------------------------------------------------------- > > Key: HIVE-7094 > URL: https://issues.apache.org/jira/browse/HIVE-7094 > Project: Hive > Issue Type: Sub-task > Components: HCatalog > Reporter: David Chen > Assignee: David Chen > Attachments: HIVE-7094.1.patch, HIVE-7094.3.patch, HIVE-7094.4.patch > > > There are two major places in FileRecordWriterContainer that have the {{if > (dynamicPartitioning)}} condition: the constructor and write(). > This is the approach that I am taking: > # Move the DP and SP code into two subclasses: > DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer. > # Make FileRecordWriterContainer an abstract class that contains the common > code for both implementations. For write(), FileRecordWriterContainer will > call an abstract method that will provide the local RecordWriter, > ObjectInspector, SerDe, and OutputJobInfo. -- This message was sent by Atlassian JIRA (v6.2#6252)