[ https://issues.apache.org/jira/browse/HIVE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041126#comment-14041126 ]
Xuefu Zhang commented on HIVE-7229: ----------------------------------- [~HS] Thanks for working on this. It seemed that your patch didn't apply to trunk somehow. Could you check/rebase if necessary? On a side note, the following is equivalent: {code} partitionValidationRegex != null && !partitionValidationRegex.equals("") {code} {code} "".equals(partitionValidationRegex) {code} > String is compared using equal in HiveMetaStore#HMSHandler#init() > ----------------------------------------------------------------- > > Key: HIVE-7229 > URL: https://issues.apache.org/jira/browse/HIVE-7229 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > Attachments: HIVE-7229.patch > > > Around line 423: > {code} > if (partitionValidationRegex != null && partitionValidationRegex != "") > { > partitionValidationPattern = > Pattern.compile(partitionValidationRegex); > {code} > partitionValidationRegex.isEmpty() can be used instead. -- This message was sent by Atlassian JIRA (v6.2#6252)