> On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Context.java, line 76 > > <https://reviews.apache.org/r/22996/diff/1/?file=617745#file617745line76> > > > > What is the purpose of removing from here? I don't see any other > > changes?
Looks like that change was not necessary, will remove. > On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 226 > > <https://reviews.apache.org/r/22996/diff/1/?file=617748#file617748line226> > > > > if (not) > > > > else > > > > This should be reversed. > > > > > > will fix in next patch > On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 317 > > <https://reviews.apache.org/r/22996/diff/1/?file=617748#file617748line317> > > > > We shouldn't lose the stack trace here MetaException does not have a constructor to propagate the cause, will try calling initCause() on the exception before throwing. > On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 332 > > <https://reviews.apache.org/r/22996/diff/1/?file=617748#file617748line332> > > > > Losing stack trace here will fix in next patch > On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line > > 10170 > > <https://reviews.apache.org/r/22996/diff/1/?file=617753#file617753line10170> > > > > Could we have a better message? will fix in next patch > On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 382 > > <https://reviews.apache.org/r/22996/diff/1/?file=617756#file617756line382> > > > > a bunch of > > > > if (not) > > > > else > > > > statements here This is an issue? I can change in next patch. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/#review46713 ----------------------------------------------------------- On June 26, 2014, 2:05 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22996/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 2:05 a.m.) > > > Review request for hive, Gunther Hagleitner, Navis Ryu, and Harish Butani. > > > Bugs: HIVE-7090 > https://issues.apache.org/jira/browse/HIVE-7090 > > > Repository: hive-git > > > Description > ------- > > Temp tables managed in memory by SessionState. > SessionHiveMetaStoreClient overrides table-related methods in HiveMetaStore > to access the temp tables saved in the SessionState when appropriate. > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > 9fb7550 > itests/qtest/testconfiguration.properties 6731561 > metastore/if/hive_metastore.thrift cc802c6 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 9e8d912 > ql/src/java/org/apache/hadoop/hive/ql/Context.java abc4290 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 24f829f > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d35176 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 3df2690 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 1270520 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f934ac4 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 71471f4 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 83d09c0 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 2537b75 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java cb5d64c > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 2143d0c > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 43125f7 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager.java 98c3cc3 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > 91de8da > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestHiveAuthorizationTaskFactory.java > 20d08b3 > ql/src/test/queries/clientnegative/temp_table_authorize_create_tbl.q > PRE-CREATION > ql/src/test/queries/clientnegative/temp_table_column_stats.q PRE-CREATION > ql/src/test/queries/clientnegative/temp_table_create_like_partitions.q > PRE-CREATION > ql/src/test/queries/clientnegative/temp_table_index.q PRE-CREATION > ql/src/test/queries/clientnegative/temp_table_partitions.q PRE-CREATION > ql/src/test/queries/clientnegative/temp_table_rename.q PRE-CREATION > ql/src/test/queries/clientpositive/show_create_table_temp_table.q > PRE-CREATION > ql/src/test/queries/clientpositive/temp_table.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_external.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_gb1.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_join1.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_names.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_options1.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_precedence.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_subquery1.q PRE-CREATION > ql/src/test/queries/clientpositive/temp_table_windowing_expressions.q > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_authorize_create_tbl.q.out > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_column_stats.q.out > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_create_like_partitions.q.out > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_index.q.out PRE-CREATION > ql/src/test/results/clientnegative/temp_table_partitions.q.out PRE-CREATION > ql/src/test/results/clientnegative/temp_table_rename.q.out PRE-CREATION > ql/src/test/results/clientpositive/show_create_table_temp_table.q.out > PRE-CREATION > ql/src/test/results/clientpositive/temp_table.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_external.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_gb1.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_join1.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_names.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_options1.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_precedence.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_subquery1.q.out PRE-CREATION > ql/src/test/results/clientpositive/temp_table_windowing_expressions.q.out > PRE-CREATION > ql/src/test/results/clientpositive/tez/temp_table.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/22996/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
