[ 
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046925#comment-14046925
 ] 

Brock Noland edited comment on HIVE-7291 at 6/28/14 5:10 PM:
-------------------------------------------------------------

I see the test `testParseFile` is commented out?

{noformat}
+      } catch (Exception e) {
+        logger.warn("Error processing Qtest property file: " + path + " does 
not exist");
{noformat}

Can we catch IOException here and log the stack trace. Just to differentiate 
from the various io errors that can occur. Does not exist, perm denied, etc.



was (Author: brocknoland):
I see the test `testParseFile` is commented out?

{format}
+      } catch (Exception e) {
+        logger.warn("Error processing Qtest property file: " + path + " does 
not exist");
{format}

Can we catch IOException here and log the stack trace. Just to differentiate 
from the various io errors that can occur. Does not exist, perm denied, etc.


> Refactor TestParser to understand test-property file
> ----------------------------------------------------
>
>                 Key: HIVE-7291
>                 URL: https://issues.apache.org/jira/browse/HIVE-7291
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: HIVE-7291.patch, trunk-mr2.properties
>
>
> NO PRECOMMIT TESTS



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to