[
https://issues.apache.org/jira/browse/HIVE-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048378#comment-14048378
]
Lefty Leverenz commented on HIVE-7231:
--------------------------------------
Woops, very sorry -- forgot to publish my second review, which requested
clarification in the description of hive.exec.orc.block.padding.tolerance in
HiveConf.java:
{code}
+ // Define the tolerance for block padding. The total padded length will
+ // always be less than the specified percentage.
{code}
My comment:
bq. Should mention that it's a percentage of stripe size, because "block
padding" sounds like percentage of block size. Could also explain that block
padding prevents stripes from straddling blocks.
But this isn't a show stopper.
> Improve ORC padding
> -------------------
>
> Key: HIVE-7231
> URL: https://issues.apache.org/jira/browse/HIVE-7231
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Affects Versions: 0.14.0
> Reporter: Prasanth J
> Assignee: Prasanth J
> Labels: orcfile
> Attachments: HIVE-7231.1.patch, HIVE-7231.2.patch, HIVE-7231.3.patch,
> HIVE-7231.4.patch, HIVE-7231.5.patch
>
>
> Current ORC padding is not optimal because of fixed stripe sizes within
> block. The padding overhead will be significant in some cases. Also padding
> percentage relative to stripe size is not configurable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
