----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review47856 -----------------------------------------------------------
This looks really good and I think it's quite close to being committed!! I think we should handle CHAR and VARCHAR schema generation in a follow-on jira. Can you file a jira for this and link it to HIVE-6806? ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java <https://reviews.apache.org/r/23387/#comment84089> Should we support AVROFILE as well? I don't like the FILE extension but the rest of the formats use this.. serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java <https://reviews.apache.org/r/23387/#comment84088> Let's throw UnsupportedOperationException here? I think it gives the user a better idea by the name alone. That is that it's not supported - Brock Noland On July 16, 2014, 3:35 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23387/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 3:35 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6806 > https://issues.apache.org/jira/browse/HIVE-6806 > > > Repository: hive-git > > > Description > ------- > > HIVE-6806: Native avro support > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/AvroStorageFormatDescriptor.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java > 1bae0a8fee04049f90b16d813ff4c96707b349c8 > > ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor > a23ff115512da5fe3167835a88d582c427585b8e > ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java > d53ebc65174d66bfeee25fd2891c69c78f9137ee > ql/src/test/queries/clientpositive/avro_compression_enabled_native.q > PRE-CREATION > ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_schema_evolution_native.q > PRE-CREATION > ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_partitioned_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_schema_evolution_native.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java > 1fe31e0034f8988d03a0c51a90904bb93e7cb157 > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java > PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23387/diff/ > > > Testing > ------- > > Added qTests and unit tests > > > Thanks, > > Ashish Singh > >