----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23470/#review48034 -----------------------------------------------------------
Ship it! Ship It! - Thejas Nair On July 17, 2014, 12:29 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23470/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 12:29 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-7404 > https://issues.apache.org/jira/browse/HIVE-7404 > > > Repository: hive-git > > > Description > ------- > > Generated Thrift files removed from diff. > New grant_revoke_privilege() method in Thrift Hive metastore interface > Existing grant/revoke privilege methods (non-thrift) have additional > grantOption arg. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java > d2b6355 > metastore/if/hive_metastore.thrift 2df4876 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > bace609 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 32da869 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 9ce717a > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 5e2cad7 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java c9c3037 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 5f9ab4d > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b7997c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ee074ea > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java a891838 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f5d0602 > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java > c32d81e > ql/src/java/org/apache/hadoop/hive/ql/plan/RevokeDesc.java eaef34c > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > f2a4004 > ql/src/test/queries/clientnegative/authorization_fail_8.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q > c8f4bc8 > ql/src/test/results/clientnegative/authorization_fail_8.q.out PRE-CREATION > ql/src/test/results/clientpositive/authorization_revoke_table_priv.q.out > 907c889 > > Diff: https://reviews.apache.org/r/23470/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
