[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072952#comment-14072952
]
Dong Chen commented on HIVE-7497:
---------------------------------
Hi, Brock, do you think shall we use $\{env:HIVE_CONF_DIR\} instead of
$\{system:HIVE_CONF_DIR\} ?
In HIVE-6037, the property default values are changed like below:
System.getProperty("xxx") to "$\{system:xxx\}"
System.getenv("xxx") to "$\{system:xxx\}"
Is it better to make the 2nd case to "$\{env:xxx\}" ? Otherwise, the property
may not get right env value in runtime.
If yes, I think the property HIVEHWIWARFILE may also need change like
HIVE_GLOBAL_INIT_FILE_LOCATION.
In old HiveConf.java, its value is System.getenv("HWI_WAR_FILE")). And in new
version, it is $\{system:HWI_WAR_FILE\}
> HIVE_GLOBAL_INIT_FILE_LOCATION should default to ${system:HIVE_CONF_DIR}
> ------------------------------------------------------------------------
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
> Reporter: Brock Noland
> Attachments: HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
