[
https://issues.apache.org/jira/browse/HIVE-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076856#comment-14076856
]
Ashish Kumar Singh commented on HIVE-7519:
------------------------------------------
[~szehon] thanks for reviewing. Addressed your concerns on RB.
Test failures above are all due to change in default value of column comments.
Its being printed as default instead of null. This change is introduced due to
the fact that source tables were earlier created by using internal functions,
which were called with null for column comments. Is it OK if I update all the
output file, 678 in count, to have correct column comment?
> Refactor QTestUtil to remove its duplication with QFileClient for qtest setup
> and teardown
> -------------------------------------------------------------------------------------------
>
> Key: HIVE-7519
> URL: https://issues.apache.org/jira/browse/HIVE-7519
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashish Kumar Singh
> Assignee: Ashish Kumar Singh
> Attachments: HIVE-7519.patch
>
>
> QTestUtil hard codes creation and dropping of source tables for qtests.
> QFileClient does the same thing but in a better way, uses q_test_init.sql and
> q_test_cleanup.sql scripts. As QTestUtil is growing quite large it makes
> sense to refactor it to use QFileClient's approach. This will also remove
> duplication of code addressing same purpose.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
