-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24073/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7543
https://issues.apache.org/jira/browse/HIVE-7543
Repository: hive-git
Description
-------
While trying to understand Hive's Thrift and Auth code I found some
inconsistencies and complaints using Hive's own Checkstyle rules. My IDE and
Sonar complained as well so I've taken the opportunity to clean this package up.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ae7cd53
itests/hive-unit/src/test/java/org/apache/hive/service/auth/TestCustomAuthentication.java
ece54a8
service/src/java/org/apache/hive/service/auth/AnonymousAuthenticationProviderImpl.java
4db0022
service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java
e51d4f4
service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java
7094b89
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 72b3e7e
service/src/java/org/apache/hive/service/auth/HttpAuthUtils.java 91d7188
service/src/java/org/apache/hive/service/auth/HttpAuthenticationException.java
bf6be47
service/src/java/org/apache/hive/service/auth/HttpCLIServiceUGIProcessor.java
8368938
service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 4b70558
service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
5342214
service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java
5e48d13
service/src/java/org/apache/hive/service/auth/PasswdAuthenticationProvider.java
2d0da3a
service/src/java/org/apache/hive/service/auth/PasswordAuthenticationProvider.java
PRE-CREATION
service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java dd788c6
service/src/java/org/apache/hive/service/auth/PlainSaslServer.java 79c44e6
service/src/java/org/apache/hive/service/auth/SaslQOP.java 0b2e7a2
service/src/java/org/apache/hive/service/auth/TSetIpAddressProcessor.java
3be4b4b
service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java
d0468b3
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
99ef8bc
Diff: https://reviews.apache.org/r/24073/diff/
Testing
-------
Thanks,
Lars Francke
