-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24086/#review49327
-----------------------------------------------------------
I'm not sure about this patch.
Something like this will now be completely garbled:
create table ${D_TBL} (d string);select * from ${D_TBL} where d = ";"; show
tables;
Even something like this won't work anymore:
select * from ${D_TBL} where d = ";"
So I'm afraid I'm on -1 on this patch as it breaks existing behavior. The only
way to do this properly is to parse the statement fully and split where needed.
beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/24086/#comment86306>
Missing space
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/24086/#comment86307>
Remove the block, unindent
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/24086/#comment86308>
Missing space after "Output"
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/24086/#comment86309>
I know the other tests are using the same convention but every IDE and
Checkstyle complain about naming simple local variables like this.
Should be testName, expectedPattern etc.
- Lars Francke
On July 31, 2014, 8:05 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24086/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 8:05 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7348
> https://issues.apache.org/jira/browse/HIVE-7348
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7348: Beeline could not parse ; separated queries provided with -e option
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java
> 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad
>
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
> 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
>
> Diff: https://reviews.apache.org/r/24086/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Ashish Singh
>
>
