> On Aug. 5, 2014, 6:15 a.m., Brock Noland wrote: > > Hi Chao, > > > > Can you share what the output looks like with the patch? > > > > Hive has thousands of ".q" file tests > > (https://github.com/apache/hive/tree/trunk/ql/src/test/queries/clientpositive) > > and most of them do an EXPLAIN. Thus I think this change might modify > > quite a few .q file tests. In which case it might be better to do a smaller > > change which only impacts Spark. > > Chao Sun wrote: > I worried about that too - after a little grep I found it might affect > quite a few places in MapWork. Perhaps we'll have to do something as Tez > does. Sorry, I'll make change to it.
Hi Brock, I've updated the patch. It basically is the same as what Tez does. Another option would be to override toString() in SparkWork, without modifying ExplainWork. Please let me know which one you think is better. Thanks. - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24297/#review49570 ----------------------------------------------------------- On Aug. 5, 2014, 6:09 a.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24297/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 6:09 a.m.) > > > Review request for hive and Brock Noland. > > > Bugs: HIVE-7607 > https://issues.apache.org/jira/browse/HIVE-7607 > > > Repository: hive-git > > > Description > ------- > > Currently, when using "Explain" under Spark mode, it displays dependency > information like this: > > STAGE PLANS: > Stage: Stage-1 > Spark > Edges: > Reducer 2 > [org.apache.hadoop.hive.ql.plan.SparkWork$Dependency@29a09c49, > org.apache.hadoop.hive.ql.plan.SparkWork$Dependency@6f7491f8] > DagName: chao_20140804145151_acc57d5a-27fa-44c0-aabc-052b318ed832:2 > .... > I think it should be improved by giving more information on the dependencies, > such as work information and edge type. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java e238ff1 > > Diff: https://reviews.apache.org/r/24297/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > >
