[
https://issues.apache.org/jira/browse/HIVE-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087454#comment-14087454
]
Hive QA commented on HIVE-7574:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12659906/HIVE-7574.1.patch
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 5877 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parquet_mixed_case
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_optimization
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
org.apache.hadoop.hive.ql.TestDDLWithRemoteMetastoreSecondNamenode.testCreateTableWithIndexAndPartitionsNonDefaultNameNode
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/183/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/183/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-183/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12659906
> CommonJoinOperator.checkAndGenObject calls LOG.Trace per row from probe side
> in a HashMap join consuming 4% of the CPU
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-7574
> URL: https://issues.apache.org/jira/browse/HIVE-7574
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.13.1
> Reporter: Mostafa Mokhtar
> Assignee: Mostafa Mokhtar
> Labels: perfomance
> Fix For: 0.14.0
>
> Attachments: HIVE-7574.1.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In Map join Log4JLogger.trace takes 4% of the CPU time as it gets called per
> row from the probe side by CommonJoinOperator.genAllOneUniqueJoinObject.
> Fix is to remove the logging code code below from
> CommonJoinOperator.genAllOneUniqueJoinObject:
> {code}
> if (allOne) {
> LOG.info("calling genAllOneUniqueJoinObject");
> genAllOneUniqueJoinObject();
> LOG.info("called genAllOneUniqueJoinObject");
> } else {
> LOG.trace("calling genUniqueJoinObject");
> genUniqueJoinObject(0, 0);
> LOG.trace("called genUniqueJoinObject");
> }
> {code}
> And
> {code}
> if (!hasEmpty && !mayHasMoreThanOne) {
> LOG.trace("calling genAllOneUniqueJoinObject");
> genAllOneUniqueJoinObject();
> LOG.trace("called genAllOneUniqueJoinObject");
> } else if (!hasEmpty && !hasLeftSemiJoin) {
> LOG.trace("calling genUniqueJoinObject");
> genUniqueJoinObject(0, 0);
> LOG.trace("called genUniqueJoinObject");
> } else {
> LOG.trace("calling genObject");
> genJoinObject();
> LOG.trace("called genObject");
> }
> {code}
> This is the call stack
> {code}
> Stack Trace Sample Count Percentage(%)
> hadoop.hive.ql.exec.MapJoinOperator.processOp(Object, int) 388 75.486
> hadoop.hive.ql.exec.CommonJoinOperator.checkAndGenObject() 121 23.541
> hadoop.hive.ql.exec.CommonJoinOperator.genAllOneUniqueJoinObject()
> 92 17.899
> commons.logging.impl.Log4JLogger.trace(Object) 20 3.891
> log4j.Category.log(String, Priority, Object, Throwable) 20
> 3.891
> log4j.Category.getEffectiveLevel() 10 1.946
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
