[
https://issues.apache.org/jira/browse/HIVE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088074#comment-14088074
]
Edward Capriolo commented on HIVE-5538:
---------------------------------------
{quote}If so, one possibility is to turn it on only for unit tests {quote}
I would not suggest this. We would be saying, "Hive 0.15 is tested and ready
for release!" A user would download and use hive 0.15 and if they found a bug
the reason would be because we are not actually testing the code we shipped.
Unless we plan on removing the non-vectorized code path we have to test it. To
do that we need the answer to some important questions:
* Is vector ALWAYS better/faster?
* Can vector capable of EVERYTHING non vector can not do?
Until we can answer yes to both of the above points, we can not remove the
non-vectorized code paths. Until we remove the non-vectorized code paths we
have to test them.
As I said above I think we need a stanza at the top of the Q files that defines
permutations of testing parameters.
--testwith vectorized+mr, vectorized+tez, !vectorized+mr
--testwith (hive.local.mode=true hive.localmode=false) etc. I think that is
the only way to keep the project sane.
> Turn on vectorization by default.
> ---------------------------------
>
> Key: HIVE-5538
> URL: https://issues.apache.org/jira/browse/HIVE-5538
> Project: Hive
> Issue Type: Sub-task
> Reporter: Jitendra Nath Pandey
> Assignee: Hari Sankar Sivarama Subramaniyan
> Attachments: HIVE-5538.1.patch, HIVE-5538.2.patch, HIVE-5538.3.patch,
> HIVE-5538.4.patch, HIVE-5538.5.patch, HIVE-5538.5.patch, HIVE-5538.6.patch
>
>
> Vectorization should be turned on by default, so that users don't have to
> specifically enable vectorization.
> Vectorization code validates and ensures that a query falls back to row
> mode if it is not supported on vectorized code path.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
