> On Aug. 11, 2014, 4:52 a.m., Brock Noland wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/AbstractEncodingAwareSerDe.java, > > line 43 > > <https://reviews.apache.org/r/24377/diff/3/?file=653662#file653662line43> > > > > Can we make these constants? "serialization.encoding" is probably > > already available somewhere. > > chengxiang li wrote: > add "serialization.encoding" to serdeConstant class if that's what you > mean here.
That file is auto-generated. In order to add the constant their, you'll have to edit serde/if/serde.thrift and then re-generate. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/#review50145 ----------------------------------------------------------- On Aug. 11, 2014, 7:30 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24377/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 7:30 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7142 > https://issues.apache.org/jira/browse/HIVE-7142 > > > Repository: hive-git > > > Description > ------- > > Currently Hive only support serialize data into UTF-8 charset bytes or > deserialize from UTF-8 bytes, real world users may want to load different > kinds of encoded data into hive directly. This jira is dedicated to support > serialize/deserialize all kinds of encoded data in SerDe layer. > For user, only need to configure serialization encoding on table level by set > serialization encoding through serde parameter, for example: > CREATE TABLE person(id INT, name STRING, desc STRING)ROW FORMAT SERDE > 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' WITH > SERDEPROPERTIES("serialization.encoding"='GBK'); > or > ALTER TABLE person SET SERDEPROPERTIES ('serialization.encoding'='GBK'); > LIMITATIONS: Only LazySimpleSerDe support "serialization.encoding" property > in this patch. > > > Diffs > ----- > > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java > 515cf25 > > serde/src/java/org/apache/hadoop/hive/serde2/AbstractEncodingAwareSerDe.java > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java > 179f9b5 > serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java b7fb048 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java > fb55c70 > > Diff: https://reviews.apache.org/r/24377/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
