[
https://issues.apache.org/jira/browse/HIVE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097828#comment-14097828
]
Hive QA commented on HIVE-7373:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12661864/HIVE-7373.4.patch
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 5896 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_decimal
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_decimal_native
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization
org.apache.hive.jdbc.TestJdbcDriver2.testDatabaseMetaData
org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/311/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/311/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-311/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12661864
> Hive should not remove trailing zeros for decimal numbers
> ---------------------------------------------------------
>
> Key: HIVE-7373
> URL: https://issues.apache.org/jira/browse/HIVE-7373
> Project: Hive
> Issue Type: Bug
> Components: Types
> Affects Versions: 0.13.0, 0.13.1
> Reporter: Xuefu Zhang
> Assignee: Sergio Peña
> Attachments: HIVE-7373.1.patch, HIVE-7373.2.patch, HIVE-7373.3.patch,
> HIVE-7373.4.patch
>
>
> Currently Hive blindly removes trailing zeros of a decimal input number as
> sort of standardization. This is questionable in theory and problematic in
> practice.
> 1. In decimal context, number 3.140000 has a different semantic meaning from
> number 3.14. Removing trailing zeroes makes the meaning lost.
> 2. In a extreme case, 0.0 has (p, s) as (1, 1). Hive removes trailing zeros,
> and then the number becomes 0, which has (p, s) of (1, 0). Thus, for a
> decimal column of (1,1), input such as 0.0, 0.00, and so on becomes NULL
> because the column doesn't allow a decimal number with integer part.
> Therefore, I propose Hive preserve the trailing zeroes (up to what the scale
> allows). With this, in above example, 0.0, 0.00, and 0.0000 will be
> represented as 0.0 (precision=1, scale=1) internally.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
