[
https://issues.apache.org/jira/browse/HIVE-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098184#comment-14098184
]
Szehon Ho commented on HIVE-7739:
---------------------------------
Ok as you are enabling tests and finding this much useful for spark-devs, I'm
fine with it then.
I think its still a bit work to run all enabled tests as the script you
described. The other concern I had was now local builds will always have
errors (as it will run all tests). We need to change it back before merge?
Or a better option is the framework can be improved so that includeQueryFiles
doesn't take precedence over -Dqfile or -Dqfile_regex flags?
> TestSparkCliDriver should not use includeQueryFiles
> ---------------------------------------------------
>
> Key: HIVE-7739
> URL: https://issues.apache.org/jira/browse/HIVE-7739
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: HIVE-7739.1-spark.patch
>
>
> By using includesQueryFile TestSparkCliDriver cannot be used by -Dqfile or
> -Dqfile_regex. These options are very useful so let's remove it.
> spark.query.files in testconfiguration.properties will still be used when run
> via the pre-commit tests to generate -Dqfiles
--
This message was sent by Atlassian JIRA
(v6.2#6252)
