-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 8:26 p.m.)
Review request for hive.
Changes
-------
Fixed decimal_trailing.q
It started failing after I did a rebase on origin/trunk
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new
'actualScale' variable is used that stores the actual scale of a value passed
to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new
HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java
46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java
1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java
2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java
b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java
4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 88268ce
ql/src/test/results/clientpositive/avro_decimal_native.q.out c8ae0fb
ql/src/test/results/clientpositive/char_pad_convert.q.out 26102e4
ql/src/test/results/clientpositive/decimal_2.q.out 934590c
ql/src/test/results/clientpositive/decimal_3.q.out 8e9a30a
ql/src/test/results/clientpositive/decimal_4.q.out 50662af
ql/src/test/results/clientpositive/decimal_5.q.out 0f24b8a
ql/src/test/results/clientpositive/decimal_6.q.out c0cad1f
ql/src/test/results/clientpositive/decimal_precision.q.out f3f2cbc
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 1d5fee9
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f25b442
ql/src/test/results/clientpositive/parquet_decimal.q.out cd87b92
ql/src/test/results/clientpositive/parquet_decimal1.q.out bd146f8
ql/src/test/results/clientpositive/serde_regex.q.out 65e7dec
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 07529b8
ql/src/test/results/clientpositive/tez/vector_data_types.q.out f577e13
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out a1183ad
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 08dd6ab
ql/src/test/results/clientpositive/windowing_navfn.q.out f2f2cb4
ql/src/test/results/clientpositive/windowing_rank.q.out 6a74a8e
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
