[ 
https://issues.apache.org/jira/browse/HIVE-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104421#comment-14104421
 ] 

Brock Noland commented on HIVE-7767:
------------------------------------

Hi [~nyang],

Thank you very much for your work on this! The patch looks great!

I did notice that there are a couple of tests where the results differ from 
mapreduce (outside the query plan). I used the following command:

{noformat}
git status | awk '/new file:/ {print $NF}' | xargs -I {} sh -c 'echo {}; diff 
-y -W 150 {} $(echo {} | perl -pe "s@/spark@@g")' | less
{noformat}

To compare all files and found that at least of the tests produce different 
results  union_remove_10 and union_remove_22.

Could you take a look?
Thanks!

> hive.optimize.union.remove does not work properly [Spark Branch]
> ----------------------------------------------------------------
>
>                 Key: HIVE-7767
>                 URL: https://issues.apache.org/jira/browse/HIVE-7767
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Na Yang
>            Assignee: Na Yang
>         Attachments: HIVE-7767.1-spark.patch, HIVE-7767.2-spark.patch
>
>
> Turing on the hive.optimize.union.remove property generates wrong union all 
> result. 
> For Example:
> {noformat}
> create table inputTbl1(key string, val string) stored as textfile;
> load data local inpath '../../data/files/T1.txt' into table inputTbl1;
> SELECT *
> FROM (
>   SELECT key, count(1) as values from inputTbl1 group by key
>   UNION ALL
>   SELECT key, count(1) as values from inputTbl1 group by key
> ) a;  
> {noformat}
> when the hive.optimize.union.remove is turned on, the query result is like: 
> {noformat}
> 1     1
> 2     1
> 3     1
> 7     1
> 8     2
> {noformat}
> when the hive.optimize.union.remove is turned off, the query result is like: 
> {noformat}
> 7     1
> 2     1
> 8     2
> 3     1
> 1     1
> 7     1
> 2     1
> 8     2
> 3     1
> 1     1
> {noformat}
> The expected query result is:
> {noformat}
> 7     1
> 2     1
> 8     2
> 3     1
> 1     1
> 7     1
> 2     1
> 8     2
> 3     1
> 1     1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to