[
https://issues.apache.org/jira/browse/HIVE-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106482#comment-14106482
]
Dong Chen commented on HIVE-4629:
---------------------------------
Hi, [~thejas], [~brocknoland], [~cwsteinbach], thanks for your precious
comments. I am working on the updated patch to address these comments, and will
let you know when the updated patch is uploaded.
bq. Earlier patch also had a method in HiveStatement to get the log. I think
that will be convenient for many users, though we need to be careful and
specify that is the only non jdbc function that is part of a public API in it.
But this can also be done as follow up work in separate jira.
[~thejas], you are right, adding a method in HiveStatement to get the log is
convenient for users. I filed a Jira HIVE-7615 and planed to add the getting
log API in jdbc level there.
bq. I didn't see this in the patch. Are you referring to something in the
Thrift IDL file or something else?
[~cwsteinbach], [~brocknoland], the latest patch still does not fulfill the
comments about backward compatibility. I will update the patch soon and let you
know. :)
The Thrift level interface TCLIService is OK.
For client and service layer interface ICLIService, although it is not RPC and
is not a public API of Hive, I think making it follow the single
request/response struct mode is also good. Will make the new fetchResults
method follow the single request/response struct model. Then remove those old
fetchResults methods.
> HS2 should support an API to retrieve query logs
> ------------------------------------------------
>
> Key: HIVE-4629
> URL: https://issues.apache.org/jira/browse/HIVE-4629
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Reporter: Shreepadma Venugopalan
> Assignee: Dong Chen
> Attachments: HIVE-4629-no_thrift.1.patch, HIVE-4629.1.patch,
> HIVE-4629.2.patch, HIVE-4629.3.patch.txt, HIVE-4629.4.patch,
> HIVE-4629.5.patch, HIVE-4629.6.patch, HIVE-4629.7.patch
>
>
> HiveServer2 should support an API to retrieve query logs. This is
> particularly relevant because HiveServer2 supports async execution but
> doesn't provide a way to report progress. Providing an API to retrieve query
> logs will help report progress to the client.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
