> On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 > > <https://reviews.apache.org/r/24472/diff/1/?file=655370#file655370line89> > > > > This doesn't look good. Can you use Map<String, ColumnStatisticsObj> > > instead? with key being fully qualified column name. > > StatsUtils.getFullyQualifiedColumnName(String dbname, String tablename, > > String colname) can be used to generate key. > > Jason Dere wrote: > There are a couple of places in the patch where we want to delete all of > the column stats for a table, which gets harder to do if you can only look up > the stats based on dbname.tabname.colname. How about I get rid of one level > of nested maps by using key tabname.dbname - so Map<String, Map<String, > ColumnStatisticsObj>>? This would give me an easy way to drop all col stats > for one table.
Getting rid of one level sounds good. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51762 ----------------------------------------------------------- On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24472/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 6:37 p.m.) > > > Review request for hive and Prasanth_J. > > > Bugs: HIVE-7649 > https://issues.apache.org/jira/browse/HIVE-7649 > > > Repository: hive-git > > > Description > ------- > > Update SessionHiveMetastoreClient to get column stats to work for temp tables. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 5a56ced > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 37b1669 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 24f3710 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 > ql/src/test/queries/clientnegative/temp_table_column_stats.q 9b7aa4a > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_column_stats.q.out 4b0c0bc > ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/24472/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
