[ https://issues.apache.org/jira/browse/HIVE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117346#comment-14117346 ]
Hive QA commented on HIVE-7306: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12665748/HIVE-7306.patch {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 6133 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing_windowspec org.apache.hadoop.hive.ql.udaf.TestStreamingAvg.testDouble_0_5 org.apache.hadoop.hive.ql.udaf.TestStreamingAvg.testDouble_3_0 org.apache.hadoop.hive.ql.udaf.TestStreamingAvg.testDouble_3_4 org.apache.hadoop.hive.ql.udaf.TestStreamingAvg.testDouble_7_2 org.apache.hive.hcatalog.pig.TestOrcHCatLoader.testReadDataPrimitiveTypes org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/590/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/590/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-590/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12665748 > Ineffective null check in > GenericUDAFAverage#GenericUDAFAverageEvaluatorDouble#getNextResult() > ---------------------------------------------------------------------------------------------- > > Key: HIVE-7306 > URL: https://issues.apache.org/jira/browse/HIVE-7306 > Project: Hive > Issue Type: Bug > Affects Versions: 0.13.1 > Reporter: Ted Yu > Priority: Minor > Labels: patch > Attachments: HIVE-7306.patch > > > {code} > Object[] o = ss.intermediateVals.remove(0); > Double d = o == null ? 0.0 : (Double) o[0]; > r = r == null ? null : r - d; > cnt = cnt - ((Long) o[1]); > {code} > Array o is accessed without null check in the last line above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)