[
https://issues.apache.org/jira/browse/HIVE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118298#comment-14118298
]
Josh Elser commented on HIVE-7928:
----------------------------------
[~skrho], I don't follow the reason for your change. The point of the
try/finally is to ensure that the {{ZipFile}} is closed before the method
returns. The code also does not handle the IOException that can be thrown and
lets the caller deal with that exception ({{throws IOException}}. A try block
does not always require a catch statement. This method looks fine to me as-is.
> There is no catch statement in Utils#updateMap
> ----------------------------------------------
>
> Key: HIVE-7928
> URL: https://issues.apache.org/jira/browse/HIVE-7928
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.13.1
> Reporter: skrho
> Assignee: skrho
> Priority: Minor
> Attachments: HIVE-7928_001.patch
>
>
> There is no catch statement in Utils class( In
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java line :
> 148)
> If there is no catch statement, We can't know why if exception is happended..
>
> I think add catch statement and throw exception..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
