----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review52070 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/25245/#comment90803> To be user friendly, please use the parameter name (hive.zookeeper.quorum) instead of HIVE_ZOOKEEPER_QUORUM. And shouldn't it say "The port for" instead of "The port of"? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/25245/#comment90804> Use the parameter name (hive.zookeeper.quorum) instead of HIVE_ZOOKEEPER_QUORUM, unless the connection string can specify it that way. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/25245/#comment90806> This would need to be rebased because HIVE-5799 just changed the default from ms to sec, but it looks like you only got rid of a space at eol -- that's already taken care of, so you don't need this change. - Lefty Leverenz On Sept. 2, 2014, 10:05 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25245/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 10:05 a.m.) > > > Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair. > > > Bugs: HIVE-7935 > https://issues.apache.org/jira/browse/HIVE-7935 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7935 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 46044d0 > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java > 59294b1 > service/src/java/org/apache/hive/service/cli/CLIService.java 08ed2e7 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 21c33bc > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > bc0a02c > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > d573592 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 37b05fc > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 027931e > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > c380b69 > service/src/java/org/apache/hive/service/server/HiveServer2.java 0864dfb > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > 66fc1fc > > Diff: https://reviews.apache.org/r/25245/diff/ > > > Testing > ------- > > Manual testing + test cases. > > > Thanks, > > Vaibhav Gumashta > >