----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25179/#review52086 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRelMdRowCount.java <https://reviews.apache.org/r/25179/#comment90821> You referring to the join with Date Dimensions in the case of TPCDS, right? AS we discussed will address the special case of the child RelNode trees containing only TScan/Filter/Project. ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRelMdUniqueKeys.java <https://reviews.apache.org/r/25179/#comment90822> yes will add logging. BTW the check based on range depends on HIVE-7915 going in, that exposes the high and low values in the ColumnStatistics object. - Harish Butani On Sept. 2, 2014, 8:23 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25179/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 8:23 p.m.) > > > Review request for hive, Gunther Hagleitner, John Pullokkaran, and Mostafa > Mokhtar. > > > Repository: hive-git > > > Description > ------- > > CBO: more cost model changes > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/HiveDefaultRelMetadataProvider.java > 2c08772 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRelMdRowCount.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRelMdSelectivity.java > df70de2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRelMdUniqueKeys.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6c293c8 > > Diff: https://reviews.apache.org/r/25179/diff/ > > > Testing > ------- > > existing tests. > > > Thanks, > > Harish Butani > >
