----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25711/#review53582 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java <https://reviews.apache.org/r/25711/#comment93297> This needs a bit-wise OR, to make sure the existing one is 733 or better. (dirPermission.toShort() & expectedDirPermission.toShort()) == expectedDirPermission.toShort() This change should not prevent anyone who uses 777 today from continuing to use it. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java <https://reviews.apache.org/r/25711/#comment93298> ws - nit - Gopal V On Sept. 16, 2014, 8:36 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25711/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 8:36 p.m.) > > > Review request for hive, Gopal V and Thejas Nair. > > > Bugs: HIVE-8143 > https://issues.apache.org/jira/browse/HIVE-8143 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8143 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 185ea95 > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > b430cae > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 241d315 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d7227ed > > Diff: https://reviews.apache.org/r/25711/diff/ > > > Testing > ------- > > Unit + manual > > > Thanks, > > Vaibhav Gumashta > >
